Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size

2020-10-29 Thread chen huacai
Hi, Richard, On Wed, Oct 28, 2020 at 4:48 PM Richard Henderson wrote: > > On 10/27/20 9:17 PM, Huacai Chen wrote: > > +invalid: > > +/* > > + * When invalid, ensure the value is bigger than or equal to > > + * the minimal but smaller than or equal to the maxium. > > + */ > > +

Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size

2020-10-28 Thread Richard Henderson
On 10/27/20 9:17 PM, Huacai Chen wrote: > +invalid: > +/* > + * When invalid, ensure the value is bigger than or equal to > + * the minimal but smaller than or equal to the maxium. > + */ > +maskbits = MIN(16, MAX(maskbits, TARGET_PAGE_BITS - 12)); > +env->CP0_PageMask = ((1