Hi, Richard, On Wed, Oct 28, 2020 at 4:48 PM Richard Henderson <richard.hender...@linaro.org> wrote: > > On 10/27/20 9:17 PM, Huacai Chen wrote: > > +invalid: > > + /* > > + * When invalid, ensure the value is bigger than or equal to > > + * the minimal but smaller than or equal to the maxium. > > + */ > > + maskbits = MIN(16, MAX(maskbits, TARGET_PAGE_BITS - 12)); > > + env->CP0_PageMask = ((1 << (16 + 1)) - 1) << CP0PM_MASK; > > maskbits is unused. Did you mean to use it? This is redundant, will be removed.
Huacai > > > r~ -- Huacai Chen