Re: [PATCH 6/6] qapi: expose all schema features to code

2024-08-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > This removed the QapiFeatures enum and auto-generates an enum which > exposes all features defined by the schema to code. > > The 'deprecated' and 'unstable' features still have a little bit of > special handling, being force defined to be the 1st + 2nd features > in

Re: [PATCH 6/6] qapi: expose all schema features to code

2024-08-02 Thread Daniel P . Berrangé
On Fri, Aug 02, 2024 at 03:50:33PM +0200, Markus Armbruster wrote: > Doesn't build for me: > > qapi/qapi-init-commands.c: In function ‘qmp_init_marshal’: > qapi/qapi-init-commands.c:70:84: error: > ‘QAPI_FEATURE_ALLOW_WRITE_ONLY_OVERLAY’ undeclared (first use in this > function) >

Re: [PATCH 6/6] qapi: expose all schema features to code

2024-08-02 Thread Markus Armbruster
Doesn't build for me: qapi/qapi-init-commands.c: In function ‘qmp_init_marshal’: qapi/qapi-init-commands.c:70:84: error: ‘QAPI_FEATURE_ALLOW_WRITE_ONLY_OVERLAY’ undeclared (first use in this function) 70 | qmp_marshal_blockdev_snapshot, QCO_ALLOW_PRECONFIG