On Fri, Aug 02, 2024 at 03:50:33PM +0200, Markus Armbruster wrote: > Doesn't build for me: > > qapi/qapi-init-commands.c: In function ‘qmp_init_marshal’: > qapi/qapi-init-commands.c:70:84: error: > ‘QAPI_FEATURE_ALLOW_WRITE_ONLY_OVERLAY’ undeclared (first use in this > function) > 70 | qmp_marshal_blockdev_snapshot, > QCO_ALLOW_PRECONFIG, 1u << QAPI_FEATURE_ALLOW_WRITE_ONLY_OVERLAY); > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > qapi/qapi-init-commands.c:70:84: note: each undeclared identifier is > reported only once for each function it appears in > qapi/qapi-init-commands.c:464:70: error: > ‘QAPI_FEATURE_SAVEVM_MONITOR_NODES’ undeclared (first use in this function) > 464 | qmp_marshal_human_monitor_command, 0, 1u > << QAPI_FEATURE_SAVEVM_MONITOR_NODES); > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
IIUC, you are doing an patch-wise build. I see this error whe nbuilding at patch 5, and its fixed by patch 6. These two patches have to be squashed together really. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|