Re: [PATCH 2/4] TCG support for AVX

2022-04-20 Thread Paul Brook
On Wed, 2022-04-20 at 16:19 +0200, Paolo Bonzini wrote: > On 4/18/22 21:45, Paul Brook wrote: > > > Massively too large for a single patch, I'm afraid. This needs > > > to be split, probably into at least twenty patches, which each > > > are a reviewable chunk of code that does one coherent thing.

Re: [PATCH 2/4] TCG support for AVX

2022-04-20 Thread Paolo Bonzini
On 4/18/22 21:45, Paul Brook wrote: Massively too large for a single patch, I'm afraid. This needs to be split, probably into at least twenty patches, which each are a reviewable chunk of code that does one coherent thing. Hmm, I'mm see what I can do. Unfortunately the table driven decoding mea

Re: [PATCH 2/4] TCG support for AVX

2022-04-18 Thread Richard Henderson
On 4/18/22 12:45, Paul Brook wrote: Unfortunately the table driven decoding means that going from two to three operands tends to be a bit all or nothing just to get the thing to compile. Yes, gen_sse is awful. Which is why the previous attempt at AVX2 rewrote the decoder: https://lore.kernel

Re: [PATCH 2/4] TCG support for AVX

2022-04-18 Thread Peter Maydell
On Mon, 18 Apr 2022 at 20:45, Paul Brook wrote: > > On Mon, 2022-04-18 at 20:33 +0100, Peter Maydell wrote: > > On Mon, 18 Apr 2022 at 18:48, Paul Brook wrote: > > > > > > Add TCG translation of guest AVX/AVX2 instructions > > > This comprises: > > > > > > > Massively too large for a single patch

Re: [PATCH 2/4] TCG support for AVX

2022-04-18 Thread Paul Brook
On Mon, 2022-04-18 at 20:33 +0100, Peter Maydell wrote: > On Mon, 18 Apr 2022 at 18:48, Paul Brook wrote: > > > > Add TCG translation of guest AVX/AVX2 instructions > > This comprises: > > > > Massively too large for a single patch, I'm afraid. This needs > to be split, probably into at least t

Re: [PATCH 2/4] TCG support for AVX

2022-04-18 Thread Peter Maydell
On Mon, 18 Apr 2022 at 18:48, Paul Brook wrote: > > Add TCG translation of guest AVX/AVX2 instructions > This comprises: > > * VEX encodings of most (all?) "legacy" SSE operations. > These typically add an extra source operand, and clear the unused half > of the destination register (SSE encod