On Wed, 2022-04-20 at 16:19 +0200, Paolo Bonzini wrote: > On 4/18/22 21:45, Paul Brook wrote: > > > Massively too large for a single patch, I'm afraid. This needs > > > to be split, probably into at least twenty patches, which each > > > are a reviewable chunk of code that does one coherent thing. > > Hmm, I'mm see what I can do. > > > > Unfortunately the table driven decoding means that going from two > > to > > three operands tends to be a bit all or nothing just to get the > > thing > > to compile. > > Hi Paul, welcome back and thanks for this huge work. It should be > possible at least to split the patch as follows (at least that's > what _I_ would do in order to review it): > [snip]
Ok, that sounds like a reasonable start. > I can do some of the work too since I was planning to do this > anyway (but have hardly started yet). I'll push my changes to https://github.com/pbrook/qemu . This is a personal project, so I'll be working on it as and when. If you have additional comments/suggestions on the approach taken then I'd be happy to hear them. Paul
