Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-18 Thread John Snow
On 12/18/20 3:57 PM, Markus Armbruster wrote: John Snow writes: On 12/18/20 12:24 AM, Markus Armbruster wrote: I could conceivably use source line information and stuff, to be needlessly fancy about it. Nah. I just think singleton patterns are kind of weird to implement in Python, so I didn't

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-18 Thread Markus Armbruster
John Snow writes: > On 12/18/20 12:24 AM, Markus Armbruster wrote: >>> I could conceivably use source line information and stuff, to be >>> needlessly fancy about it. Nah. I just think singleton patterns are kind >>> of weird to implement in Python, so I didn't. >> Stupidest singleton that could

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-18 Thread John Snow
On 12/18/20 12:24 AM, Markus Armbruster wrote: I could conceivably use source line information and stuff, to be needlessly fancy about it. Nah. I just think singleton patterns are kind of weird to implement in Python, so I didn't. Stupidest singleton that could possibly work: in __init__, self.s

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-17 Thread Markus Armbruster
John Snow writes: > On 12/17/20 3:02 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 12/16/20 5:18 AM, Markus Armbruster wrote: John Snow writes: > -- > > events.py had an info to route, was it by choice that it wasn't before? See below. I

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-17 Thread John Snow
On 12/17/20 3:02 AM, Markus Armbruster wrote: John Snow writes: On 12/16/20 5:18 AM, Markus Armbruster wrote: John Snow writes: -- events.py had an info to route, was it by choice that it wasn't before? See below. I figure this is intentionally below the -- line, but ... Signed-off-b

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-17 Thread Markus Armbruster
John Snow writes: > On 12/16/20 5:18 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> -- >>> >>> events.py had an info to route, was it by choice that it wasn't before? >> >> See below. >> >> I figure this is intentionally below the -- line, but ... >> >>> Signed-off-by: John Snow >

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-16 Thread John Snow
On 12/16/20 5:18 AM, Markus Armbruster wrote: John Snow writes: -- events.py had an info to route, was it by choice that it wasn't before? See below. I figure this is intentionally below the -- line, but ... Signed-off-by: John Snow ... this should be above it. Script failure. Or h

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-16 Thread Markus Armbruster
John Snow writes: > -- > > events.py had an info to route, was it by choice that it wasn't before? See below. I figure this is intentionally below the -- line, but ... > Signed-off-by: John Snow ... this should be above it. > --- > scripts/qapi/events.py | 2 +- > scripts/qapi/schema.py |