Re: [PATCH] virtio: Drop broken and superfluous object_property_set_link()

2020-07-23 Thread Cornelia Huck
On Tue, 21 Jul 2020 14:11:53 +0200 Markus Armbruster wrote: > virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's > property "cryptodev" to vcrypto's property: > > object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng), > NULL);

Re: [PATCH] virtio: Drop broken and superfluous object_property_set_link()

2020-07-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/21/20 2:11 PM, Markus Armbruster wrote: > > Is there a line missing here? > >> virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's > > ^^^ > Scratch "and". I started describing two of the four cases together, th

Re: [PATCH] virtio: Drop broken and superfluous object_property_set_link()

2020-07-21 Thread Philippe Mathieu-Daudé
On 7/21/20 2:11 PM, Markus Armbruster wrote: Is there a line missing here? > virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's ^^^ > property "cryptodev" to vcrypto's property: > > object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vd