Re: [PATCH] qapi: make machine type deprecation a warning

On Thu, May 12, 2022 at 02:24:35PM +0200, Paolo Bonzini wrote: > On 5/12/22 12:46, Markus Armbruster wrote: > > Commit message nitpick: not sure this is "qapi:". The commit that > > introduced "Machine type ... is deprecated" (08fe68244eb) used > > "hw/i386:". We commonly use "vl:", "softmmu:", a

Re: [PATCH] qapi: make machine type deprecation a warning

On 5/12/22 12:46, Markus Armbruster wrote: Commit message nitpick: not sure this is "qapi:". The commit that introduced "Machine type ... is deprecated" (08fe68244eb) used "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for this file. Will do. I wonder if I should already pr

Re: [PATCH] qapi: make machine type deprecation a warning

Commit message nitpick: not sure this is "qapi:". The commit that introduced "Machine type ... is deprecated" (08fe68244eb) used "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for this file.

Re: [PATCH] qapi: make machine type deprecation a warning

Paolo Bonzini writes: > On 5/11/22 20:44, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Signed-off-by: Paolo Bonzini >>> --- >>> softmmu/vl.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/softmmu/vl.c b/softmmu/vl.c >>> index c2919579fd..fbef0f5c5

Re: [PATCH] qapi: make machine type deprecation a warning

On 5/11/22 20:44, Markus Armbruster wrote: Paolo Bonzini writes: Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index c2919579fd..fbef0f5c5f 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3723,

Re: [PATCH] qapi: make machine type deprecation a warning

Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > softmmu/vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index c2919579fd..fbef0f5c5f 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -3723,7 +3723,7 @@ void qemu_init(i