Paolo Bonzini <pbonz...@redhat.com> writes: > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > softmmu/vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index c2919579fd..fbef0f5c5f 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -3723,7 +3723,7 @@ void qemu_init(int argc, char **argv, char **envp) > > machine_class = MACHINE_GET_CLASS(current_machine); > if (!qtest_enabled() && machine_class->deprecation_reason) { > - error_report("Machine type '%s' is deprecated: %s", > + warn_report("Machine type '%s' is deprecated: %s", > machine_class->name, machine_class->deprecation_reason); > }
Anti-pattern: error_report() not followed by "fail function". The commit only changes the message printed to stderr. The commit message made me expect it would change an actual (fatal?) error into a mere warning. It's too late in my day to come up with a clearer phrasing, so Reviewed-by: Markus Armbruster <arm...@redhat.com>