Re: [PATCH] meson: use thorough test setup as default

On 5/8/25 3:05 AM, Thomas Huth wrote: On 07/05/2025 20.45, Pierrick Bouvier wrote: On 5/7/25 12:39 AM, Thomas Huth wrote: Then I don't understand the previous argument from Thomas to not make thorough the default: "The thorough functional tests download a lot of assets from the internet, so if

Re: [PATCH] meson: use thorough test setup as default

On 07/05/2025 20.45, Pierrick Bouvier wrote: On 5/7/25 12:39 AM, Thomas Huth wrote: Then I don't understand the previous argument from Thomas to not make thorough the default: "The thorough functional tests download a lot of assets from the internet, so if someone just runs "meson test" without

Re: [PATCH] meson: use thorough test setup as default

On 5/7/25 12:39 AM, Thomas Huth wrote: Then I don't understand the previous argument from Thomas to not make thorough the default: "The thorough functional tests download a lot of assets from the internet, so if someone just runs "meson test" without further parameters, I think we should not trig

Re: [PATCH] meson: use thorough test setup as default

On 07/05/2025 09.14, Daniel P. Berrangé wrote: On Tue, May 06, 2025 at 07:12:53PM +0200, Thomas Huth wrote: On 06/05/2025 17.31, Pierrick Bouvier wrote: On 5/6/25 2:33 AM, Daniel P. Berrangé wrote: On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: On 5/5/25 3:32 AM, Thomas Hut

Re: [PATCH] meson: use thorough test setup as default

On Tue, May 06, 2025 at 07:12:53PM +0200, Thomas Huth wrote: > On 06/05/2025 17.31, Pierrick Bouvier wrote: > > On 5/6/25 2:33 AM, Daniel P. Berrangé wrote: > > > On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: > > > > On 5/5/25 3:32 AM, Thomas Huth wrote: > > > > > On 03/05/2025

Re: [PATCH] meson: use thorough test setup as default

On 06/05/2025 17.31, Pierrick Bouvier wrote: On 5/6/25 2:33 AM, Daniel P. Berrangé wrote: On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: On 5/5/25 3:32 AM, Thomas Huth wrote: On 03/05/2025 22.18, Pierrick Bouvier wrote: Allows all tests to be visible by default when using m

Re: [PATCH] meson: use thorough test setup as default

On Tue, May 06, 2025 at 08:31:07AM -0700, Pierrick Bouvier wrote: > On 5/6/25 2:33 AM, Daniel P. Berrangé wrote: > > On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: > > > On 5/5/25 3:32 AM, Thomas Huth wrote: > > > > On 03/05/2025 22.18, Pierrick Bouvier wrote: > > > > > Allows al

Re: [PATCH] meson: use thorough test setup as default

On 5/6/25 2:33 AM, Daniel P. Berrangé wrote: On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: On 5/5/25 3:32 AM, Thomas Huth wrote: On 03/05/2025 22.18, Pierrick Bouvier wrote: Allows all tests to be visible by default when using meson test directly. This has no impact on mak

Re: [PATCH] meson: use thorough test setup as default

On 06/05/2025 11.36, Daniel P. Berrangé wrote: On Sat, May 03, 2025 at 01:18:06PM -0700, Pierrick Bouvier wrote: Allows all tests to be visible by default when using meson test directly. This has no impact on make check-* commands, which use SPEED=quick by default (see scripts/mtest2make.py).

Re: [PATCH] meson: use thorough test setup as default

On Sat, May 03, 2025 at 01:18:06PM -0700, Pierrick Bouvier wrote: > Allows all tests to be visible by default when using meson test > directly. > > This has no impact on make check-* commands, which use SPEED=quick by > default (see scripts/mtest2make.py). IMHO it would be conceptually confusing

Re: [PATCH] meson: use thorough test setup as default

On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: > On 5/5/25 3:32 AM, Thomas Huth wrote: > > On 03/05/2025 22.18, Pierrick Bouvier wrote: > > > Allows all tests to be visible by default when using meson test > > > directly. > > > > > > This has no impact on make check-* commands,

Re: [PATCH] meson: use thorough test setup as default

On 5/5/25 3:32 AM, Thomas Huth wrote: On 03/05/2025 22.18, Pierrick Bouvier wrote: Allows all tests to be visible by default when using meson test directly. This has no impact on make check-* commands, which use SPEED=quick by default (see scripts/mtest2make.py). Signed-off-by: Pierrick Bouvie

Re: [PATCH] meson: use thorough test setup as default

On 5/4/25 11:00 PM, Paolo Bonzini wrote: Il sab 3 mag 2025, 22:18 Pierrick Bouvier > ha scritto: Allows all tests to be visible by default when using meson test directly. This has no impact on make check-* commands, which use SPEED=quick by

Re: [PATCH] meson: use thorough test setup as default

On 03/05/2025 22.18, Pierrick Bouvier wrote: Allows all tests to be visible by default when using meson test directly. This has no impact on make check-* commands, which use SPEED=quick by default (see scripts/mtest2make.py). Signed-off-by: Pierrick Bouvier --- meson.build | 5 +++-- 1 file

Re: [PATCH] meson: use thorough test setup as default

Il sab 3 mag 2025, 22:18 Pierrick Bouvier ha scritto: > Allows all tests to be visible by default when using meson test > directly. > > This has no impact on make check-* commands, which use SPEED=quick by > default (see scripts/mtest2make.py). > What's the advantage of having different defaults