On 5/4/25 11:00 PM, Paolo Bonzini wrote:
Il sab 3 mag 2025, 22:18 Pierrick Bouvier <pierrick.bouv...@linaro.org
<mailto:pierrick.bouv...@linaro.org>> ha scritto:
Allows all tests to be visible by default when using meson test
directly.
This has no impact on make check-* commands, which use SPEED=quick by
default (see scripts/mtest2make.py).
What's the advantage of having different defaults depending on whether
you use "make check" or "meson test"?
"make check" can be seen as a blackbox, where you have different
targets, but don't really do things on a per test basis. At least, it's
not the workflow that was implemented.
"meson test", on the opposite, expose the list of tests to you.
My rationale here is to expose all tests for meson test (instead of
having to add --setup thorough everytime), and let the "per setup"
workflow to make command.
I don't oppose this change per se, but if it's useful it should be
matched by a change in the default SPEED.
As Thomas pointed, running thorough tests by default would take more
time/more disk space, and I'm not sure we want to change what is done in
our CI or for people by default.
This change is just supposed to be convenience for people using meson
test directly, without impacting "make check*" users.
So when you want to run a single test, it's visible from
"meson test -C build --list", by default.
Paolo
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org
<mailto:pierrick.bouv...@linaro.org>>
---
meson.build | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index f8bf6e7bb66..57ff3f722d8 100644
--- a/meson.build
+++ b/meson.build
@@ -5,12 +5,13 @@ project('qemu', ['c'], meson_version: '>=1.5.0',
meson.add_devenv({ 'MESON_BUILD_ROOT' : meson.project_build_root() })
-add_test_setup('quick', exclude_suites: ['slow', 'thorough'],
is_default: true,
+add_test_setup('quick', exclude_suites: ['slow', 'thorough'],
env: ['RUST_BACKTRACE=1'])
add_test_setup('slow', exclude_suites: ['thorough'],
env: ['G_TEST_SLOW=1', 'SPEED=slow',
'RUST_BACKTRACE=1'])
add_test_setup('thorough',
- env: ['G_TEST_SLOW=1', 'SPEED=thorough',
'RUST_BACKTRACE=1'])
+ env: ['G_TEST_SLOW=1', 'SPEED=thorough',
'RUST_BACKTRACE=1'],
+ is_default: true)
meson.add_postconf_script(find_program('scripts/symlink-install-
tree.py'))
--
2.47.2
