RE: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh)

2021-04-06 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, April 6, 2021 3:51 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; a...@rev.ng; Brian Cain > Subject: Re: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS > (vacsh) &

Re: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh)

2021-04-06 Thread Richard Henderson
On 3/31/21 8:53 PM, Taylor Simpson wrote: +#define fGEN_TCG_A5_ACS(SHORTCODE) \ +do { \ +gen_helper_vacsh_val(RxxV, cpu_env, RxxV, RssV, RttV); \ +gen_helper_vacsh_pred(PeV, cpu_env, RxxV, RssV, RttV); \ +} while (0) You've modified RxxV before its last use. I think just