Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-08-03 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 02:04:42PM +0200, Thomas Huth wrote: > On 31/07/2023 11.32, Daniel P. Berrangé wrote: > > On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: > ... > > > Or do you see another possibility how we could fix that timeout problem in > > > the 64-bit MSYS2 job? Still swi

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.49, Daniel P. Berrangé wrote: ... If the value of the msys2 jobs is that they let us run the test suite, can we limit the usage of msys2 to just that part, and chain it upto the fedora mingw cross compile jobs ie. win64-fedora-cross-container | +-> cross-win64-syste

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-08-01 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 11:05:42AM +0100, Peter Maydell wrote: > On Mon, 31 Jul 2023 at 10:11, Thomas Huth wrote: > > Or do you see another possibility how we could fix that timeout problem in > > the 64-bit MSYS2 job? Still switching to clang, but compiling with > > --extra-cflags="-Wno-unknown-a

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-08-01 Thread Philippe Mathieu-Daudé
On 31/7/23 19:25, Daniel P. Berrangé wrote: On Mon, Jul 31, 2023 at 04:10:36PM +0200, Philippe Mathieu-Daudé wrote: On 31/7/23 11:32, Daniel P. Berrangé wrote: I was surprised to see that we're not using ccache in gitlab CI. It wouldn't help the from-clean compile time, but thereafter it ought

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 04:10:36PM +0200, Philippe Mathieu-Daudé wrote: > On 31/7/23 11:32, Daniel P. Berrangé wrote: > > > I was surprised to see that we're not using ccache in gitlab CI. It wouldn't > > help the from-clean compile time, but thereafter it ought to help. I'm doing > > some tests w

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Philippe Mathieu-Daudé
On 31/7/23 11:32, Daniel P. Berrangé wrote: I was surprised to see that we're not using ccache in gitlab CI. It wouldn't help the from-clean compile time, but thereafter it ought to help. I'm doing some tests with that to see the impact. I tried that few years ago and this had very negative im

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Philippe Mathieu-Daudé
On 31/7/23 14:57, Daniel P. Berrangé wrote: On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: Anyway, using bitfields in structs for exchanging data with the guest is just way too error-prone, as you can see in the discussion about that VTD_IR_TableEntry in my other patch. We should m

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: > Anyway, using bitfields in structs for exchanging data with the guest is > just way too error-prone, as you can see in the discussion about that > VTD_IR_TableEntry in my other patch. We should maybe advise against > bitfields in our co

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 11:05:42AM +0100, Peter Maydell wrote: > On Mon, 31 Jul 2023 at 10:11, Thomas Huth wrote: > > Or do you see another possibility how we could fix that timeout problem in > > the 64-bit MSYS2 job? Still switching to clang, but compiling with > > --extra-cflags="-Wno-unknown-a

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Thomas Huth
On 31/07/2023 12.05, Peter Maydell wrote: On Mon, 31 Jul 2023 at 10:11, Thomas Huth wrote: Or do you see another possibility how we could fix that timeout problem in the 64-bit MSYS2 job? Still switching to clang, but compiling with --extra-cflags="-Wno-unknown-attributes" maybe? Is there any

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Thomas Huth
On 31/07/2023 11.32, Daniel P. Berrangé wrote: On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: ... Or do you see another possibility how we could fix that timeout problem in the 64-bit MSYS2 job? Still switching to clang, but compiling with --extra-cflags="-Wno-unknown-attributes"

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Peter Maydell
On Mon, 31 Jul 2023 at 10:11, Thomas Huth wrote: > Or do you see another possibility how we could fix that timeout problem in > the 64-bit MSYS2 job? Still switching to clang, but compiling with > --extra-cflags="-Wno-unknown-attributes" maybe? Is there any way we can separate out the "take 25 mi

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Daniel P . Berrangé
On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: > On 28/07/2023 17.13, Peter Maydell wrote: > > On Fri, 28 Jul 2023 at 15:28, Thomas Huth wrote: > > > > > > Clang on Windows does not seem to know the "gcc_struct" attribute > > > and emits a warning when we try to use it. Add an addit

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-31 Thread Thomas Huth
On 28/07/2023 17.13, Peter Maydell wrote: On Fri, 28 Jul 2023 at 15:28, Thomas Huth wrote: Clang on Windows does not seem to know the "gcc_struct" attribute and emits a warning when we try to use it. Add an additional check here with __has_attribute() to avoid this problem. Signed-off-by: Tho

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-28 Thread Peter Maydell
On Fri, 28 Jul 2023 at 15:28, Thomas Huth wrote: > > Clang on Windows does not seem to know the "gcc_struct" attribute > and emits a warning when we try to use it. Add an additional check > here with __has_attribute() to avoid this problem. > > Signed-off-by: Thomas Huth > --- > include/qemu/com

[RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-07-28 Thread Thomas Huth
Clang on Windows does not seem to know the "gcc_struct" attribute and emits a warning when we try to use it. Add an additional check here with __has_attribute() to avoid this problem. Signed-off-by: Thomas Huth --- include/qemu/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di