On 31/7/23 14:57, Daniel P. Berrangé wrote:
On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote:
Anyway, using bitfields in structs for exchanging data with the guest is
just way too error-prone, as you can see in the discussion about that
VTD_IR_TableEntry in my other patch. We should maybe advise against
bitfields in our coding style and point people to registerfields.h instead
for new code? ... so that we use QEMU_PACKED mainly for legacy code. Would
it then be OK for you, Peter, to go on with this approach?
The registerfields.h usage doesn't seem to be documented at all from the
quick look I had. IOW, in addition to a mention in coding style, it would
be nice if someone can document the general usage pattern for it.
Cc'ing ex-Xilinx folks.
With regards,
Daniel
