Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-02 Thread Xiaoyao Li
On 8/2/2023 12:52 AM, Claudio Fontana wrote: On 8/1/23 18:48, Claudio Fontana wrote: On 7/31/23 18:21, Xiaoyao Li wrote: Signed-off-by: Xiaoyao Li --- include/exec/memory.h | 9 + softmmu/memory.c | 5 + 2 files changed, 14 insertions(+) diff --git a/include/exec/memory.h

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 8/1/23 18:48, Claudio Fontana wrote: > On 7/31/23 18:21, Xiaoyao Li wrote: >> Signed-off-by: Xiaoyao Li >> --- >> include/exec/memory.h | 9 + >> softmmu/memory.c | 5 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/include/exec/memory.h b/include/exec/memory.h >> in

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 7/31/23 18:21, Xiaoyao Li wrote: > Signed-off-by: Xiaoyao Li > --- > include/exec/memory.h | 9 + > softmmu/memory.c | 5 + > 2 files changed, 14 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 61e31c7b9874..e119d3ce1a1d 100644 > --- a/inc

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Sean Christopherson
On Mon, Jul 31, 2023, Peter Xu wrote: > On Mon, Jul 31, 2023 at 05:36:37PM -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2023 at 02:34:22PM -0700, Sean Christopherson wrote: > > > On Mon, Jul 31, 2023, Peter Xu wrote: > > > > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > >

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Peter Xu
On Mon, Jul 31, 2023 at 05:36:37PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 31, 2023 at 02:34:22PM -0700, Sean Christopherson wrote: > > On Mon, Jul 31, 2023, Peter Xu wrote: > > > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > > > +bool memory_region_can_be_private(MemoryReg

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Michael S. Tsirkin
On Mon, Jul 31, 2023 at 02:34:22PM -0700, Sean Christopherson wrote: > On Mon, Jul 31, 2023, Peter Xu wrote: > > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > > +bool memory_region_can_be_private(MemoryRegion *mr) > > > +{ > > > +return mr->ram_block && mr->ram_block->gmem_fd

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Sean Christopherson
On Mon, Jul 31, 2023, Peter Xu wrote: > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > +bool memory_region_can_be_private(MemoryRegion *mr) > > +{ > > +return mr->ram_block && mr->ram_block->gmem_fd >= 0; > > +} > > This is not really MAP_PRIVATE, am I right? If so, is there

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Michael S. Tsirkin
On Mon, Jul 31, 2023 at 05:23:55PM -0400, Peter Xu wrote: > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > +bool memory_region_can_be_private(MemoryRegion *mr) > > +{ > > +return mr->ram_block && mr->ram_block->gmem_fd >= 0; > > +} > > This is not really MAP_PRIVATE, am I righ

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Peter Xu
On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > +bool memory_region_can_be_private(MemoryRegion *mr) > +{ > +return mr->ram_block && mr->ram_block->gmem_fd >= 0; > +} This is not really MAP_PRIVATE, am I right? If so, is there still chance we rename it (it seems to be also in th

[RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-07-31 Thread Xiaoyao Li
Signed-off-by: Xiaoyao Li --- include/exec/memory.h | 9 + softmmu/memory.c | 5 + 2 files changed, 14 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 61e31c7b9874..e119d3ce1a1d 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -167