Re: [Qemu-devel] checkpatch.pl question

2014-06-08 Thread Paolo Bonzini
Il 07/06/2014 18:27, Peter Maydell ha scritto: On 7 June 2014 17:00, Stefan Weil wrote: Am 07.06.2014 16:58, schrieb Peter Maydell: It's clearly something to do with it getting confused by the type name, because you can suppress the warning by just changing it so it has an "_t" suffix, for ins

Re: [Qemu-devel] checkpatch.pl question

2014-06-07 Thread Peter Maydell
On 7 June 2014 17:00, Stefan Weil wrote: > Am 07.06.2014 16:58, schrieb Peter Maydell: >> It's clearly something to do with it getting confused by the type name, >> because you can suppress the warning by just changing it so it has >> an "_t" suffix, for instance. In particular notice that the set

Re: [Qemu-devel] checkpatch.pl question

2014-06-07 Thread Stefan Weil
Am 07.06.2014 16:58, schrieb Peter Maydell: > On 6 June 2014 08:17, Markus Armbruster wrote: >> --debug values=1 produces >> >> 188 > . extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid, >> 188 > EEVVVNTTVVCCVVVCC >> >> which sugg

Re: [Qemu-devel] checkpatch.pl question

2014-06-07 Thread Peter Maydell
On 6 June 2014 08:17, Markus Armbruster wrote: > --debug values=1 produces > > 188 > . extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid, > 188 > EEVVVNTTVVCCVVVCC > > which suggests it recognizes the declaration just fine. > > Co

Re: [Qemu-devel] checkpatch.pl question

2014-06-06 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 06/06/2014 04:27 PM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> Hi! >>> >>> checkpatch.pl often complains on things like this: >>> >>> === >>> ERROR: need consistent spacing around '*' (ctx:WxV) >>> #57: FILE: hw/misc/vfio.c:4323: >>> +int

Re: [Qemu-devel] checkpatch.pl question

2014-06-05 Thread Alexey Kardashevskiy
On 06/06/2014 04:27 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> Hi! >> >> checkpatch.pl often complains on things like this: >> >> === >> ERROR: need consistent spacing around '*' (ctx:WxV) >> #57: FILE: hw/misc/vfio.c:4323: >> +int vfio_container_ioctl(AddressSpace *as, int3

Re: [Qemu-devel] checkpatch.pl question

2014-06-05 Thread Markus Armbruster
Alexey Kardashevskiy writes: > Hi! > > checkpatch.pl often complains on things like this: > > === > ERROR: need consistent spacing around '*' (ctx:WxV) > #57: FILE: hw/misc/vfio.c:4323: > +int vfio_container_ioctl(AddressSpace *as, int32_t groupid, >^ > > t

[Qemu-devel] checkpatch.pl question

2014-06-05 Thread Alexey Kardashevskiy
Hi! checkpatch.pl often complains on things like this: === ERROR: need consistent spacing around '*' (ctx:WxV) #57: FILE: hw/misc/vfio.c:4323: +int vfio_container_ioctl(AddressSpace *as, int32_t groupid, ^ total: 1 errors, 0 warnings, 46 lines checked ===