On 06/06/2014 04:27 PM, Markus Armbruster wrote: > Alexey Kardashevskiy <a...@ozlabs.ru> writes: > >> Hi! >> >> checkpatch.pl often complains on things like this: >> >> === >> ERROR: need consistent spacing around '*' (ctx:WxV) >> #57: FILE: hw/misc/vfio.c:4323: >> +int vfio_container_ioctl(AddressSpace *as, int32_t groupid, >> ^ >> >> total: 1 errors, 0 warnings, 46 lines checked >> === >> >> Since perl is a write-only language, I cannot understand why :) Any clue? > > It misinterprets the '*' as infix operator, because it doesn't recognize > 'AddressSpace *as' is a declaration. Sorry, this isn't much of a clue, > but you didn't provide much of a reproducer. >
Ooops. Sorry about that. The failing patch has been posted today: [PATCH v8 2/4] vfio: Add vfio_container_ioctl() And the failing chunk is: diff --git a/include/hw/misc/vfio.h b/include/hw/misc/vfio.h new file mode 100644 index 0000000..0b26cd8 --- /dev/null +++ b/include/hw/misc/vfio.h @@ -0,0 +1,9 @@ +#ifndef VFIO_API_H +#define VFIO_API_H + +#include "qemu/typedefs.h" + +extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid, + int req, void *param); + +#endif -- Alexey
