Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-24 Thread Luiz Capitulino
On Mon, 24 May 2010 14:29:58 -0500 Anthony Liguori wrote: > On 05/20/2010 02:22 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 13:52:08 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 01:47 PM, Luiz Capitulino wrote: > >> > >>> On Thu, 20 May 2010 11:55:00 -0500 > >>> A

Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-24 Thread Anthony Liguori
On 05/20/2010 02:22 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 13:52:08 -0500 Anthony Liguori wrote: On 05/20/2010 01:47 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: O

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 13:52:08 -0500 Anthony Liguori wrote: > On 05/20/2010 01:47 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 11:55:00 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 11:27 AM, Luiz Capitulino wrote: > >> > >>> On Thu, 20 May 2010 10:50:41 -0500 > >>> A

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 01:47 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: > On 05/20/2010 11:27 AM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 10:50:41 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 10:16 AM, Paolo Bonzini wrote: > >> > >>> On 05/20/2010 03:44 PM, Luiz Capitulino wrot

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec say

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:54:42 -0500 Anthony Liguori wrote: > On 05/20/2010 10:35 AM, Luiz Capitulino wrote: > >> I meant that we're just accepting some invalid JSON and that's not a big > >> deal. > >> > > It can become a big deal if clients rely on it and for some reason we > > decide we

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: > On 05/20/2010 10:16 AM, Paolo Bonzini wrote: > > On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > >> I think there's another issue in the handling of strings. > >> > >> The spec says that valid unescaped chars are in the following ra

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:35 AM, Luiz Capitulino wrote: I meant that we're just accepting some invalid JSON and that's not a big deal. It can become a big deal if clients rely on it and for some reason we decide we should drop it. Ie. after QMP is declared stable such changes won't be allowed.

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 That's a spec bug IM

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:26:03 +0200 Paolo Bonzini wrote: > On 05/20/2010 05:25 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 17:16:01 +0200 > > Paolo Bonzini wrote: > > > >> On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > >>>I think there's another issue in the handling of strings. > >>

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzini wrote: > On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > > I think there's another issue in the handling of strings. > > > > The spec says that valid unescaped chars are in the following range: > > > > unescaped = %x20-21 / %x23-5B / %x5D

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 05:25 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: un

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 But we do: [IN_DQ_STRING] = { [1 ... 0xFF] = IN_DQ