Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:59:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > > Sorry, I lost you here. What "works for IO-based fw-cf

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > MMIO-based". Undefined IO ports return -1, u

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > >>> Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > >>> MMIO-based". > >> Undefined IO ports return -1, undefined (/wrt read acc

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: >>> Sorry, I lost you here. What "works for IO-based fw-cfg, but not for >>> MMIO-based". >> Undefined IO ports return -1, undefined (/wrt read access) MMIO 0. So >> you need to select a key that is different from bot

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > > Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > > MMIO-based". > > Undefined IO ports return -1, undefined (/wrt read access) MMIO 0. So > you need to select a key that is different from both. > But can we rely

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 09:17:51AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 11:33:

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 09:17:51AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 09:57:

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: > >> On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > >>> Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: >>> Gleb Natapov wrote: On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 09:51:

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > > Gleb Natapov wrote: > > > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > > >> Gleb Natapov wrote: > > >>> On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kisz

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On W

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >>

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > There is no need starti

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: From: Jan Kiszka There is no need starting with the special value for hpet_cfg.count. Either Seabios is aware

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> There is no need starting with the special value for hpet_cfg.count. > >> Either Seabios is aware of the new firmware in

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> There is no need starting with the special value for hpet_cfg.count. >> Either Seabios is aware of the new firmware interface and properly >> interprets the counter or it simply ignores it a

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-15 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > There is no need starting with the special value for hpet_cfg.count. > Either Seabios is aware of the new firmware interface and properly > interprets the counter or it simply ignores it anyway. > I want seabios t