Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Peter Maydell
On 28 July 2014 10:49, Stefan Hajnoczi wrote: > On Mon, Jul 28, 2014 at 06:03:45AM +, Gonglei (Arei) wrote: >> Hi, >> >> Should be easy to fix though. Does the following help? >> >> (Cc'ing Stefan & Kevin) >> >> --> >> xen_disk: fix possible null-ptr dereference >> >> Signed-off-by: Gonglei

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, July 28, 2014 5:49 PM > To: Gonglei (Arei) > Cc: mateusz.krzywi...@windowslive.com; qemu-devel@nongnu.org; > kw...@redhat.com > Subject: Re: [Qemu-devel] Possible null-ptr derefer

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Stefan Hajnoczi
On Mon, Jul 28, 2014 at 06:03:45AM +, Gonglei (Arei) wrote: > Hi, > > Should be easy to fix though. Does the following help? > > (Cc'ing Stefan & Kevin) > > --> > xen_disk: fix possible null-ptr dereference > > Signed-off-by: Gonglei > --- > hw/block/xen_disk.c | 1 + > 1 file changed, 1 i

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread mateusz.krzywicki
Hey, Yup, thanks, task closed ;-) Best regards, Mateusz Krzywicki From: arei.gong...@huawei.com To: mateusz.krzywi...@windowslive.com; qemu-devel@nongnu.org CC: stefa...@redhat.com; kw...@redhat.com Subject: RE: [Qemu-devel] Possible null-ptr dereference Date: Mon, 28 Jul 2014 06:03:45 +

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-27 Thread Gonglei (Arei)
common.rsp_prod_pvt++; -- Best regards, -Gonglei From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of mateusz.krzywi...@windowslive.com Sent: Saturday, July 26, 2014 6:52 PM To: qemu-devel@nongnu.org Subject: [Qemu-devel

[Qemu-devel] Possible null-ptr dereference

2014-07-26 Thread mateusz.krzywicki
Hey, Found a little bug in latest qemu: In function: static int blk_send_response_one(struct ioreq *ioreq) File: qemu\hw\block\xen_disk.c Code: default:dst = NULL;}memcpy(dst, &resp, sizeof(resp)); Just add simple check for dst and it will be all cool ;-) Best regards,Mateusz K