On Mon, Jul 28, 2014 at 06:03:45AM +0000, Gonglei (Arei) wrote: > Hi, > > Should be easy to fix though. Does the following help? > > (Cc'ing Stefan & Kevin) > > --> > xen_disk: fix possible null-ptr dereference > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > --- > hw/block/xen_disk.c | 1 + > 1 file changed, 1 insertion(+)
This code path can never be reached since protocol is always set to one of 3 valid values in xen_disk.c. Therefore, I'm not merging this for QEMU 2.1 where we are only taking critical bug fixes now. Still, it will help silence static checkers and make the intent clear to readers. Thanks, applied to my block-next tree for QEMU 2.2: https://github.com/stefanha/qemu/commits/block-next Stefan
pgpu0OfPHR42l.pgp
Description: PGP signature
