Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-26 Thread Markus Armbruster
Thomas Huth writes: > On 2018-11-21 19:14, Markus Armbruster wrote: >> Time for another update. My HEAD is at v3.1.0-rc2. > > Thanks a lot for this, Markus, very appreciated! > > [...] >> Unmaintained files sorted by number of commits in the past year >> (v2.11.0-rc2): >> >> $ for i in `cat unm

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-23 Thread Philippe Mathieu-Daudé
On 23/11/18 11:56, BALATON Zoltan wrote: > On Fri, 23 Nov 2018, Philippe Mathieu-Daudé wrote: >> On 22/11/18 22:56, BALATON Zoltan wrote: >>> While we're there, should I also add pc-bios/canyonlands.dts which is >>> the device tree for sam460ex? >> >> Yes, I suggest this set: >> >> pc-bios/canyonla

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-23 Thread BALATON Zoltan
On Fri, 23 Nov 2018, Philippe Mathieu-Daudé wrote: On 22/11/18 22:56, BALATON Zoltan wrote: While we're there, should I also add pc-bios/canyonlands.dts which is the device tree for sam460ex? Yes, I suggest this set: pc-bios/canyonlands.dt? pc-bios/u-boot-sam460* roms/u-boot-sam460ex Well,

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-22 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 22/11/18 22:56, BALATON Zoltan wrote: > On Thu, 22 Nov 2018, Thomas Huth wrote: >>> 19 hw/display/sm501.c >> >> Maybe Balaton wants to adopt this file? > > As discussed before this was originally part of SH4 but since that seems > to be not actively maintained any more and late

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-22 Thread BALATON Zoltan
On Thu, 22 Nov 2018, Thomas Huth wrote: 19 hw/display/sm501.c Maybe Balaton wants to adopt this file? As discussed before this was originally part of SH4 but since that seems to be not actively maintained any more and latest changes were for sam460ex I can add it to sam460ex. I planned

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-22 Thread Thomas Huth
On 2018-11-21 19:14, Markus Armbruster wrote: > Time for another update. My HEAD is at v3.1.0-rc2. Thanks a lot for this, Markus, very appreciated! [...] > Unmaintained files sorted by number of commits in the past year > (v2.11.0-rc2): > > $ for i in `cat unmaintained-files`; do echo -n "$i ";

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-21 Thread Markus Armbruster
Time for another update. My HEAD is at v3.1.0-rc2. Markus Armbruster writes: > Markus Armbruster writes: > >> Paolo asked for an update. > > Another update; HEAD is commit e00da55. A.k.a. v2.7.0-rc5~7. >> Markus Armbruster writes: >> >>> Markus Armbruster writes: >>> In my experience,

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-09-23 Thread Thomas Huth
On 23.09.2016 14:56, Thomas Huth wrote: > On 30.08.2016 13:31, Markus Armbruster wrote: > [...] > Ideas? Takers? Full list of unmaintained files now: > [...] >> hw/misc/applesmc.c > > Is this file used at all anymore? I can't see any code that instantiates > this device ... so maybe

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-09-23 Thread Thomas Huth
On 30.08.2016 13:31, Markus Armbruster wrote: [...] Ideas? Takers? >>> >>> Full list of unmaintained files now: [...] > hw/misc/applesmc.c Is this file used at all anymore? I can't see any code that instantiates this device ... so maybe that's a good candidate for clean-up, unless somebody v

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-09-12 Thread Thomas Huth
On 30.08.2016 13:31, Markus Armbruster wrote: > Markus Armbruster writes: > >> Paolo asked for an update. > > Another update; HEAD is commit e00da55. [...] >>> Full list of unmaintained files now: [...] > default-configs/aarch64-linux-user.mak > default-configs/aarch64-softmmu.mak > default-conf

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-31 Thread Markus Armbruster
I really shouldn't reply to this, because more maintainer duties is about the last thing I need, but here goes anyway: Paolo Bonzini writes: > On 30/08/2016 17:29, Markus Armbruster wrote: >> > > > Active subsystems lacking a maintainer include tilegx, qdev, replay. >> > > >> > > You, Eduardo,

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread John Snow
On 08/30/2016 08:57 AM, Peter Maydell wrote: On 30 August 2016 at 13:48, Paolo Bonzini wrote: I think this is expected to some extent. Is it worth moving tests to many tests subdirectories, e.g. hw/scsi/tests? Many files would be covered automatically. Moving tests around in order to incr

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 17:29, Markus Armbruster wrote: > > > > Active subsystems lacking a maintainer include tilegx, qdev, replay. > > > > > > You, Eduardo, me? > > > > FWIW I was referring to qdev. > > Jointly? A subset not including me would also be fine. But since the git fallback still exists, and

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/08/2016 14:48, Paolo Bonzini wrote: >> > Active subsystems lacking a maintainer include tilegx, qdev, replay. >> >> You, Eduardo, me? > > FWIW I was referring to qdev. Jointly? [...]

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:48, Paolo Bonzini wrote: > > Active subsystems lacking a maintainer include tilegx, qdev, replay. > > You, Eduardo, me? FWIW I was referring to qdev. As to replay, it is mostly by Pavel but the remaining changes would need review by the relevant maintainers (e.g. USB for USB r

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 13:31:12 +0200 Markus Armbruster wrote: > >> Full list of unmaintained files now: > docs/virtio-migration.txt I wrote this so I guess I could maintain it; but it should probably go with the other core virtio stuff? > default-configs/s390x-softmmu.mak > include/hw/watchdog/w

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 14:40:05 +0200 Paolo Bonzini wrote: > On 30/08/2016 14:26, Cornelia Huck wrote: > > Same goes for linux-headers. We don't even touch those (beyond the > > massaging done by the import script). > > > > Maybe we could make get_maintainers.pl point at the maintainer for > > the

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 13:48, Paolo Bonzini wrote: > I think this is expected to some extent. Is it worth moving tests to > many tests subdirectories, e.g. hw/scsi/tests? Many files would be > covered automatically. Moving tests around in order to increase MAINTAINERS coverage seems to me to be p

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 13:31, Markus Armbruster wrote: > $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f > --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done > >unmaintained-files > $ grep -c '\.c$' unmaintained-files > 402 > > 402 out of 2132 (19%). More prog

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:26, Cornelia Huck wrote: > Same goes for linux-headers. We don't even touch those (beyond the > massaging done by the import script). > > Maybe we could make get_maintainers.pl point at the maintainer for > the import script for these headers? Or is there something more > clever

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 13:31:12 +0200 Markus Armbruster wrote: > >> Full list of unmaintained files now: (...) > include/standard-headers/asm-s390/kvm_virtio.h > include/standard-headers/asm-s390/virtio-ccw.h > include/standard-headers/asm-x86/hyperv.h > include/standard-headers/linux/if_ether.h >

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Markus Armbruster
Markus Armbruster writes: > Paolo asked for an update. Another update; HEAD is commit e00da55. > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> In my experience, too many files are not covered by MAINTAINERS. >>> scripts/get_maintainer.pl falls back to git then, unless you sa

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-24 Thread Markus Armbruster
Alberto Garcia writes: > On Wed 23 Sep 2015 10:24:55 AM CEST, Kevin Wolf wrote: > >>> > include/qemu/throttle.h >>> >>> Block? >> >> Would be covered if it were in the correct place (include/block/). Let's move it to the correct place then. >> Should we add a separate section for I/O throttli

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > On 09/22/2015 03:13 AM, Markus Armbruster wrote: > >>> Full list of unmaintained files now: >> [...] >> > >> docs/bitmaps.md >> docs/blkdebug.txt >> docs/blkverify.txt > >> docs/live-block-ops.txt > >> docs/qcow2-cache.txt >> docs/qdev-device-use.txt > >> docs/specs/qcow2.tx

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-23 Thread Alberto Garcia
On Wed 23 Sep 2015 10:24:55 AM CEST, Kevin Wolf wrote: >> > include/qemu/throttle.h >> >> Block? > > Would be covered if it were in the correct place (include/block/). > > Should we add a separate section for I/O throttling, maintained by > Berto, as well? So far it's part of the block layer cor

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-23 Thread Kevin Wolf
Am 22.09.2015 um 20:07 hat Eric Blake geschrieben: > On 09/22/2015 03:13 AM, Markus Armbruster wrote: > > >> Full list of unmaintained files now: > > [...] > > > > > docs/bitmaps.md > > docs/blkdebug.txt > > docs/blkverify.txt > > > docs/live-block-ops.txt > > > docs/qcow2-cache.txt > > docs/q

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 22/09/2015 20:07, Eric Blake wrote: > On 09/22/2015 03:13 AM, Markus Armbruster wrote: > >>> Full list of unmaintained files now: >> [...] >> > >> docs/bitmaps.md docs/blkdebug.txt docs/blkverify.txt > >> docs/live-block-ops.txt > >> docs/q

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread John Snow
On 09/22/2015 05:13 AM, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: >> >> Full list of unmaintained files now: > [...] > Full list edited down to 'sections' with replies in-line... [ top level confetti/detritus ] [ backends/* ] [ coroutine-* ] [ defaul

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Eric Blake
On 09/22/2015 03:13 AM, Markus Armbruster wrote: >> Full list of unmaintained files now: > [...] > > docs/bitmaps.md > docs/blkdebug.txt > docs/blkverify.txt > docs/live-block-ops.txt > docs/qcow2-cache.txt > docs/qdev-device-use.txt > docs/specs/qcow2.txt > docs/specs/qed_spec.txt Kevin, St

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Peter Maydell
On 22 September 2015 at 07:58, Daniel P. Berrange wrote: > On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: >> Paolo asked for an update. >> >> Markus Armbruster writes: >> >> > Markus Armbruster writes: >> Different tack: what are the unmaintained files we actually change? >>

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Juan Quintela
Thomas Huth wrote: > On 22/09/15 11:13, Markus Armbruster wrote: > >> docs/migration.txt > > Juan? Reviewed-by: Juan Quintela O;-)

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: > > > Markus Armbruster writes: > Different tack: what are the unmaintained files we actually change? > > Unmaintained files sorted by number of commits in the past yea

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Gerd Hoffmann
Hi, > > docs/usb-storage.txt > > docs/usb2.txt > > include/hw/usb.h > > include/hw/usb/ehci-regs.h > > include/hw/usb/uhci-regs.h > > include/ui/console.h > > include/ui/egl-helpers.h > > include/ui/gtk.h > > include/ui/input.h > > include/ui/pixel_ops.h > > include/ui/qemu-pixman.h > > include

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Thomas Huth
On 22/09/15 11:13, Markus Armbruster wrote: ... >> Full list of unmaintained files now: [...] > default-configs/aarch64-linux-user.mak > default-configs/aarch64-softmmu.mak > default-configs/alpha-linux-user.mak > default-configs/alpha-softmmu.mak > default-configs/arm-linux-user.mak > default-conf

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 12:06, Daniel P. Berrange wrote: > We could extend the checkpatch.pl script so that it reports an error > if the patch contains a new file which is not covered by MAINTAINERS. > That would immediately prevent the situation getting any worse. Actually Linux has such a check. Any vo

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: > > > Markus Armbruster writes: > > > >> In my experience, too many files are not covered by MAINTAINERS. > >> scripts/get_maintainer.pl falls back to git then, unless y

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Markus Armbruster
Paolo asked for an update. Markus Armbruster writes: > Markus Armbruster writes: > >> In my experience, too many files are not covered by MAINTAINERS. >> scripts/get_maintainer.pl falls back to git then, unless you say >> --no-git-fallback. Copies sent there tends to annoy their recipients >>

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> In my experience, too many files are not covered by MAINTAINERS. >> scripts/get_maintainer.pl falls back to git then, unless you say >> --no-git-fallback. Copies sent there tends to annoy their recipients >> without accomplishing all that muc

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Alex Bennée
Markus Armbruster writes: > In my experience, too many files are not covered by MAINTAINERS. > scripts/get_maintainer.pl falls back to git then, unless you say > --no-git-fallback. Copies sent there tends to annoy their recipients > without accomplishing all that much. > > Two obvious improveme

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Paolo Bonzini
On 10/22/2014 03:06 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 10/22/2014 01:45 PM, Markus Armbruster wrote: > Part of TCG PPC. >>> Give me a name :) >>> >> >> This: >> >> PowerPC >> M: Alexander Graf >> L: qemu-...@nongnu.org >> S: Maintained >> F: target-ppc/ >> F: hw/p

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Alexander Graf
On 22.10.14 15:06, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 10/22/2014 01:45 PM, Markus Armbruster wrote: > Part of TCG PPC. >>> Give me a name :) >>> >> >> This: >> >> PowerPC >> M: Alexander Graf >> L: qemu-...@nongnu.org >> S: Maintained >> F: target-ppc/ >> F: hw/ppc/ >

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/22/2014 01:45 PM, Markus Armbruster wrote: >>> > Part of TCG PPC. >> Give me a name :) >> > > This: > > PowerPC > M: Alexander Graf > L: qemu-...@nongnu.org > S: Maintained > F: target-ppc/ > F: hw/ppc/ > > Paolo Something like this, I presume: diff --git a/M

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Luiz Capitulino
On Wed, 22 Oct 2014 13:45:44 +0200 Markus Armbruster wrote: > >> qobject/Makefile.objs > >> qobject/json-lexer.c > >> qobject/json-parser.c > >> qobject/json-streamer.c > >> qobject/qbool.c > >> qobject/qdict.c > >> qobject/qerror.c > >> qobject/qfloat.c > >> qobject/qint.c > >> qobject/qjson.c >

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Michael Roth
Quoting Markus Armbruster (2014-10-22 06:45:44) > Paolo Bonzini writes: > > >> Down to 491 our of 1841 (27%). Progress, but not quite enough. > > > > I think a better analysis would be on patches, not files. Which is > > really hard to do, of course. > > > > But as a rule of thumb, tests/ and i

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Paolo Bonzini
On 10/22/2014 01:45 PM, Markus Armbruster wrote: >> > Part of TCG PPC. > Give me a name :) > This: PowerPC M: Alexander Graf L: qemu-...@nongnu.org S: Maintained F: target-ppc/ F: hw/ppc/ Paolo

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Markus Armbruster
Paolo Bonzini writes: >> Down to 491 our of 1841 (27%). Progress, but not quite enough. > > I think a better analysis would be on patches, not files. Which is > really hard to do, of course. > > But as a rule of thumb, tests/ and include/ patches should also touch > files outside those director

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Paolo Bonzini
> Down to 491 our of 1841 (27%). Progress, but not quite enough. I think a better analysis would be on patches, not files. Which is really hard to do, of course. But as a rule of thumb, tests/ and include/ patches should also touch files outside those directories. Not many people, unfortunatel

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Markus Armbruster
Markus Armbruster writes: > In my experience, too many files are not covered by MAINTAINERS. > scripts/get_maintainer.pl falls back to git then, unless you say > --no-git-fallback. Copies sent there tends to annoy their recipients > without accomplishing all that much. > > Two obvious improvemen

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-20 Thread Paolo Bonzini
On 10/20/2014 11:19 AM, Markus Armbruster wrote: In my experience, too many files are not covered by MAINTAINERS. scripts/get_maintainer.pl falls back to git then, unless you say --no-git-fallback. Copies sent there tends to annoy their recipients without accomplishing all that much. Two obviou

[Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-20 Thread Markus Armbruster
In my experience, too many files are not covered by MAINTAINERS. scripts/get_maintainer.pl falls back to git then, unless you say --no-git-fallback. Copies sent there tends to annoy their recipients without accomplishing all that much. Two obvious improvements: * Easy: Flip scripts/get_maintaine