Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread wang.yi59
>On Wed, Jul 19, 2017 at 08:17:49PM +0100, Dr. David Alan Gilbert wrote: >> * Eduardo Habkost (address@hidden) wrote: >> > On Wed, Jul 19, 2017 at 10:17:36AM -0500, Eric Blake wrote: >> > > On 07/19/2017 10:07 AM, Daniel P. Berrange wrote: >> > > >> It doesn't. Perhaps we should add that as a

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 08:17:49PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Wed, Jul 19, 2017 at 10:17:36AM -0500, Eric Blake wrote: > > > On 07/19/2017 10:07 AM, Daniel P. Berrange wrote: > > > >> It doesn't. Perhaps we should add that as a futu

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Wed, Jul 19, 2017 at 10:17:36AM -0500, Eric Blake wrote: > > On 07/19/2017 10:07 AM, Daniel P. Berrange wrote: > > >> It doesn't. Perhaps we should add that as a future libvirt-qemu.so API > > >> addition, although it's probably easier to just us

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 10:17:36AM -0500, Eric Blake wrote: > On 07/19/2017 10:07 AM, Daniel P. Berrange wrote: > >> It doesn't. Perhaps we should add that as a future libvirt-qemu.so API > >> addition, although it's probably easier to just use QMP than HMP when > >> using 'virsh qemu-monitor-comm

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eric Blake
On 07/19/2017 10:07 AM, Daniel P. Berrange wrote: >> It doesn't. Perhaps we should add that as a future libvirt-qemu.so API >> addition, although it's probably easier to just use QMP than HMP when >> using 'virsh qemu-monitor-command' if HMP doesn't do what you want. > > Or special case the "cpu

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Daniel P. Berrange
On Wed, Jul 19, 2017 at 10:02:04AM -0500, Eric Blake wrote: > [adding libvirt] > > On 07/19/2017 07:41 AM, Eduardo Habkost wrote: > > >> virsh qemu-monitor-command --domain rhel6.8 --hmp --cmd "cpu 1" > >> virsh qemu-monitor-command --domain rhel6.8 --hmp --cmd "info lapic" > >> dumping local A

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eric Blake
[adding libvirt] On 07/19/2017 07:41 AM, Eduardo Habkost wrote: >> virsh qemu-monitor-command --domain rhel6.8 --hmp --cmd "cpu 1" >> virsh qemu-monitor-command --domain rhel6.8 --hmp --cmd "info lapic" >> dumping local APIC state for CPU 0 > > Right, the "cpu" command is useless inside a > 'h

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 01:16:28PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Wed, Jul 19, 2017 at 12:47:53PM +0800, wang.y...@zte.com.cn wrote: > > > Hi Eduardo, > > > > > > Thank you for your reply! > > > > > > >On Mon, Jul 17, 2017 at 09:49:37P

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Wed, Jul 19, 2017 at 12:47:53PM +0800, wang.y...@zte.com.cn wrote: > > Hi Eduardo, > > > > Thank you for your reply! > > > > >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > > >> Add [vcpu] index support for hmp command "info lapic",

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 12:47:53PM +0800, wang.y...@zte.com.cn wrote: > Hi Eduardo, > > Thank you for your reply! > > >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > >> Add [vcpu] index support for hmp command "info lapic", which is > >> useful when debugging ipi and so on. Current be

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Wed, 19 Jul 2017 16:48:23 +0800 (CST) wrote: > >* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: > > > >> Hi Eduardo, > > >> > > >> Thank you for your reply! > > >> > > >> >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > > >> > > >> >> Add [vcpu] index s

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread wang.yi59
>* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: >> Hi Eduardo, >> >> Thank you for your reply! >> >> >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: >> >> >> Add [vcpu] index support for hmp command "info lapic", which is >> >> >> useful when debugging ipi and so on. C

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Dr. David Alan Gilbert
* wang.y...@zte.com.cn (wang.y...@zte.com.cn) wrote: > Hi Eduardo, > > Thank you for your reply! > > >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > > >> Add [vcpu] index support for hmp command "info lapic", which is > > >> useful when debugging ipi and so on. Current behavior is n

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Tue, 18 Jul 2017 20:26:50 -0300 Eduardo Habkost wrote: > On Tue, Jul 18, 2017 at 04:54:17PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jul 2017 21:49:37 -0400 > > Yi Wang wrote: > > > > > Add [vcpu] index support for hmp command "info lapic", which is > > > useful when debugging ipi and so o

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-19 Thread Igor Mammedov
On Wed, 19 Jul 2017 12:25:53 +0800 (CST) wrote: > >On Mon, 17 Jul 2017 21:49:37 -0400 > > >Yi Wang wrote: > > > > > >> Add [vcpu] index support for hmp command "info lapic", which is > > >> useful when debugging ipi and so on. Current behavior is not > > >> changed when the parameter isn't

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread wang.yi59
Hi Eduardo, Thank you for your reply! >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: >> Add [vcpu] index support for hmp command "info lapic", which is >> useful when debugging ipi and so on. Current behavior is not >> changed when the parameter isn't specified. >> >> Signed-off-

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread wang.yi59
>On Mon, 17 Jul 2017 21:49:37 -0400 >Yi Wang wrote: > >> Add [vcpu] index support for hmp command "info lapic", which is >> useful when debugging ipi and so on. Current behavior is not >> changed when the parameter isn't specified. >we shouldn't expose cpu_index to users anymore, > >I woul

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread Eduardo Habkost
On Tue, Jul 18, 2017 at 04:54:17PM +0200, Igor Mammedov wrote: > On Mon, 17 Jul 2017 21:49:37 -0400 > Yi Wang wrote: > > > Add [vcpu] index support for hmp command "info lapic", which is > > useful when debugging ipi and so on. Current behavior is not > > changed when the parameter isn't specifie

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread Eduardo Habkost
On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote: > Add [vcpu] index support for hmp command "info lapic", which is > useful when debugging ipi and so on. Current behavior is not > changed when the parameter isn't specified. > > Signed-off-by: Yi Wang > Signed-off-by: Yun Liu We have 8 m

Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread Igor Mammedov
On Mon, 17 Jul 2017 21:49:37 -0400 Yi Wang wrote: > Add [vcpu] index support for hmp command "info lapic", which is > useful when debugging ipi and so on. Current behavior is not > changed when the parameter isn't specified. we shouldn't expose cpu_index to users anymore, I would suggest using t

[Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"

2017-07-18 Thread Yi Wang
Add [vcpu] index support for hmp command "info lapic", which is useful when debugging ipi and so on. Current behavior is not changed when the parameter isn't specified. Signed-off-by: Yi Wang Signed-off-by: Yun Liu --- hmp-commands-info.hx | 6 +++--- target/i386/monitor.c | 8 +++- 2 file