Re: [Qemu-devel] [RfC PATCH 08/11] spice: add qxl device

2010-04-16 Thread Gerd Hoffmann
On 04/15/10 00:21, Alexander Graf wrote: On 14.04.2010, at 11:55, Gerd Hoffmann wrote: +static inline void atomic_or(uint32_t *var, uint32_t add) +{ + __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : "memory"); I hope this is going away? I don't see why QXL should be

Re: [Qemu-devel] [RfC PATCH 08/11] spice: add qxl device

2010-04-14 Thread Alexander Graf
On 14.04.2010, at 11:55, Gerd Hoffmann wrote: > > +static inline void atomic_or(uint32_t *var, uint32_t add) > +{ > + __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : > "memory"); I hope this is going away? I don't see why QXL should be coupled to x86 host and guest only

Re: [Qemu-devel] [RfC PATCH 08/11] spice: add qxl device

2010-04-14 Thread Blue Swirl
On 4/14/10, Gerd Hoffmann wrote: > +static inline void atomic_or(uint32_t *var, uint32_t add) > +{ > + __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : > "memory"); > +} This will break on non-x86 hosts. > +static QXLInterface qxl_interface = { > +.base.type

[Qemu-devel] [RfC PATCH 08/11] spice: add qxl device

2010-04-14 Thread Gerd Hoffmann
--- Makefile.target |2 +- hw/hw.h | 14 + hw/pc.c |8 + hw/qxl.c| 1035 +++ hw/vga_int.h|2 +- qemu-spice.h|2 + sysemu.h|3 +- vl.c|4 +- 8 files changed, 1066 insert