Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2018-01-12 Thread Eric Blake
On 01/11/2018 10:28 PM, Peter Xu wrote: > On Thu, Jan 11, 2018 at 05:07:11PM -0600, Eric Blake wrote: >> On 12/19/2017 02:45 AM, Peter Xu wrote: >>> There was no QMP capabilities defined. Define the first "oob" as >> >> s/was/were/ > > Fixed. > > Just to confirm: is "There was no QMP capability"

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2018-01-11 Thread Peter Xu
On Thu, Jan 11, 2018 at 05:07:11PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > There was no QMP capabilities defined. Define the first "oob" as > > s/was/were/ Fixed. Just to confirm: is "There was no QMP capability" also correct? > > > capability to allow out-of-ba

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2018-01-11 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > There was no QMP capabilities defined. Define the first "oob" as s/was/were/ > capability to allow out-of-band messages. > > Also, touch up qmp-test.c to test the new bits. > > Signed-off-by: Peter Xu > --- > monitor.c| 10 -- > qapi-

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2018-01-08 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:41PM +0800, Peter Xu wrote: > There was no QMP capabilities defined. Define the first "oob" as > capability to allow out-of-band messages. > > Also, touch up qmp-test.c to test the new bits. > > Signed-off-by: Peter Xu > --- > monitor.c| 10 -- > q

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 05:56:37PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index 4b2bee773f..81fb0a42b4 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -3943,12 +3943,18 @@ void monitor_resume(Monitor *mon) > > > > static QO

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2017-12-21 Thread Fam Zheng
On Tue, 12/19 16:45, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index 4b2bee773f..81fb0a42b4 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -3943,12 +3943,18 @@ void monitor_resume(Monitor *mon) > > static QObject *get_qmp_greeting(void) > { > +QList *cap_list = qlist_new(); >

[Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2017-12-19 Thread Peter Xu
There was no QMP capabilities defined. Define the first "oob" as capability to allow out-of-band messages. Also, touch up qmp-test.c to test the new bits. Signed-off-by: Peter Xu --- monitor.c| 10 -- qapi-schema.json | 13 + tests/qmp-test.c | 10 +- 3 file