On Thu, Dec 21, 2017 at 05:56:37PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index 4b2bee773f..81fb0a42b4 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -3943,12 +3943,18 @@ void monitor_resume(Monitor *mon) > > > > static QObject *get_qmp_greeting(void) > > { > > + QList *cap_list = qlist_new(); > > QObject *ver = NULL; > > + QMPCapability cap; > > > > qmp_marshal_query_version(NULL, &ver, NULL); > > > > - return qobject_from_jsonf("{'QMP': {'version': %p, 'capabilities': > > []}}", > > - ver); > > + for (cap = 0; cap < QMP_CAPABILITY__MAX; cap++) { > > + qlist_append(cap_list, qstring_from_str(QMPCapability_str(cap))); > > Did we want to not include "oob" if current monitor doesn't have use_io_thr?
Yes. As you have already noticed, it's in next patch. :) Thanks, -- Peter Xu