Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Peter Maydell
On 5 July 2018 at 18:14, Steffen Görtz wrote: > I would like to provide all four devices (NVMC, CODE, FICR, UICR) from > one module and rename nrf51_nvmc.[ch] to nrf51_nvm.[ch]. Is this > acceptable or would you rather prefer three modules? Yeah, that would be ok too. thanks -- PMM

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Steffen Görtz
Hello Peter, thank you for your very elaborate remarks! > [ CPU ] -+- [ NVM, either FICR, UICR or CODE ] > | | > \- [ NVMC ] > > where the CPU can talk to either the NVMC or the NVMs, and the > NVMC also has a control connection to the NVM. (See the block > diagram in th

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-05 Thread Peter Maydell
On 3 July 2018 at 10:31, Stefan Hajnoczi wrote: > On Mon, Jul 02, 2018 at 01:18:35PM +0100, Peter Maydell wrote: >> It's not clear to me what this device is doing with its >> AddressSpace, though; comments that went into more detail >> about what the device is and what the "memory" property is >>

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-03 Thread Steffen Görtz
> Is the flash memory region only accessible to the CPU > via the NVMC, or can the CPU get at it both directly > and via the NVMC? (That is, in hardware, does the flash > sit "behind" the NVMC?) > > thanks > -- PMM > The latter is the case. Steffen

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-03 Thread Peter Maydell
On 3 July 2018 at 10:31, Stefan Hajnoczi wrote: > On Mon, Jul 02, 2018 at 01:18:35PM +0100, Peter Maydell wrote: >> It's not clear to me what this device is doing with its >> AddressSpace, though; comments that went into more detail >> about what the device is and what the "memory" property is >>

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-03 Thread Stefan Hajnoczi
On Mon, Jul 02, 2018 at 01:18:35PM +0100, Peter Maydell wrote: > On 27 June 2018 at 10:44, Stefan Hajnoczi wrote: > > On Tue, Jun 26, 2018 at 11:32:04AM +0200, Steffen Görtz wrote: > >> Changes since V1: > >> - Code style changes > > > > Please put the changelog below '---'. > > > >> diff --git a/

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-07-02 Thread Peter Maydell
On 27 June 2018 at 10:44, Stefan Hajnoczi wrote: > On Tue, Jun 26, 2018 at 11:32:04AM +0200, Steffen Görtz wrote: >> Changes since V1: >> - Code style changes > > Please put the changelog below '---'. > >> diff --git a/hw/nvram/nrf51_nvmc.c b/hw/nvram/nrf51_nvmc.c >> new file mode 100644 >> index

Re: [Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-06-27 Thread Stefan Hajnoczi
On Tue, Jun 26, 2018 at 11:32:04AM +0200, Steffen Görtz wrote: > Changes since V1: > - Code style changes Please put the changelog below '---'. > diff --git a/hw/nvram/nrf51_nvmc.c b/hw/nvram/nrf51_nvmc.c > new file mode 100644 > index 00..5dde3088a8 > --- /dev/null > +++ b/hw/nvram/nrf51

[Qemu-devel] [RFC v2] arm: Add NRF51 SOC non-volatile memory controller

2018-06-26 Thread Steffen Görtz
Changes since V1: - Code style changes Signed-off-by: Steffen Görtz --- hw/nvram/Makefile.objs| 1 + hw/nvram/nrf51_nvmc.c | 168 ++ include/hw/nvram/nrf51_nvmc.h | 51 +++ 3 files changed, 220 insertions(+) create mode 100644 hw/nvram/