Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench

2014-12-01 Thread Stefan Hajnoczi
On Fri, Nov 28, 2014 at 01:19:59PM +0100, Kevin Wolf wrote: > Am 28.11.2014 um 12:49 hat Stefan Hajnoczi geschrieben: > > On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote: > > > +while (data.n > 0) { > > > +main_loop_wait(false); > > > +} > > > > Why is this false (non-bl

Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench

2014-11-28 Thread Kevin Wolf
Am 28.11.2014 um 12:49 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote: > > +while (data.n > 0) { > > +main_loop_wait(false); > > +} > > Why is this false (non-blocking)? This is why you get the main loop > spun warning message. > > U

Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench

2014-11-28 Thread Stefan Hajnoczi
On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote: > +while (data.n > 0) { > +main_loop_wait(false); > +} Why is this false (non-blocking)? This is why you get the main loop spun warning message. Using true (blocking) seems like the right thing. data.n changes as part o

[Qemu-devel] [RFC PATCH 1/3] qemu-img bench

2014-11-26 Thread Kevin Wolf
This adds a qemu-img command that allows doing some simple benchmarks for the block layer without involving guest devices and a real VM. For the start, this implements only a test of sequential reads. Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx | 6 ++ qemu-img.c | 174 ++