Am 28.11.2014 um 12:49 hat Stefan Hajnoczi geschrieben:
> On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote:
> > + while (data.n > 0) {
> > + main_loop_wait(false);
> > + }
>
> Why is this false (non-blocking)? This is why you get the main loop
> spun warning message.
>
> Using true (blocking) seems like the right thing. data.n changes as
> part of the callback, which is invoked from the main loop. There is no
> need to be non-blocking.
I think the parameter has exactly the opposite meaning as what you
describe:
int main_loop_wait(int nonblocking)
If it were true, you would get timeout = 0. qemu-io and qemu-nbd also
pass false here.
Kevin
pgpXvxB1_UHSR.pgp
Description: PGP signature
