Re: [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation

2012-09-17 Thread Richard Henderson
On 09/17/2012 12:17 PM, Blue Swirl wrote: >> > +void tcg_exec_init(unsigned long tb_size) >> > +{ >> > +#ifndef CONFIG_TCG >> > +/* We cannot yet use tcg_enabled() here, it is set below. */ >> > +return; > This leaves a lot of unreachable code after return, possibly > introducing warnings

Re: [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 4:00 PM, Paolo Bonzini wrote: > Add stubs for cpu_restore_state and tlb_fill, which should respectively > have no effect and never be used outside TCG mode. > > Add assertions that TCG is enabled around code that calls to TCG from > exec.c, so that the compiler can remove t

[Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation

2012-09-17 Thread Paolo Bonzini
Add stubs for cpu_restore_state and tlb_fill, which should respectively have no effect and never be used outside TCG mode. Add assertions that TCG is enabled around code that calls to TCG from exec.c, so that the compiler can remove the entire functions as dead (the proper way to do this should be