On 09/17/2012 12:17 PM, Blue Swirl wrote: >> > +void tcg_exec_init(unsigned long tb_size) >> > +{ >> > +#ifndef CONFIG_TCG >> > + /* We cannot yet use tcg_enabled() here, it is set below. */ >> > + return; > This leaves a lot of unreachable code after return, possibly > introducing warnings and with low enough optimization level, maybe > break linking. Please add #else and move #endif to end of the > function. >
No, this really should work all the time. Certainly gcc will not warn for unreachable code after return, and will even at -O0 remove it. r~