Re: [Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-27 Thread no-reply
/sdhci: Move PCI-related code into a separate file Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback b

Re: [Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-20 Thread Philippe Mathieu-Daudé
On 2/20/19 5:31 PM, Paolo Bonzini wrote: > On 20/02/19 13:26, Philippe Mathieu-Daudé wrote: >> On 2/20/19 1:06 PM, Thomas Huth wrote: >>> Some machines have an SDHCI device, but no PCI. To be able to >>> compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions >>> like pci_get_address_s

Re: [Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-20 Thread Paolo Bonzini
On 20/02/19 13:26, Philippe Mathieu-Daudé wrote: > On 2/20/19 1:06 PM, Thomas Huth wrote: >> Some machines have an SDHCI device, but no PCI. To be able to >> compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions >> like pci_get_address_space() and pci_allocate_irq() there. Thus >> mo

Re: [Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-20 Thread Philippe Mathieu-Daudé
On 2/20/19 1:06 PM, Thomas Huth wrote: > Some machines have an SDHCI device, but no PCI. To be able to > compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions > like pci_get_address_space() and pci_allocate_irq() there. Thus > move the PCI-related code into a separate file. > > This

[Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-20 Thread Thomas Huth
Some machines have an SDHCI device, but no PCI. To be able to compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions like pci_get_address_space() and pci_allocate_irq() there. Thus move the PCI-related code into a separate file. This is required for the upcoming Kconfig-like build sy