Patchew URL: https://patchew.org/QEMU/1550664389-2865-1-git-send-email-th...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1550664389-2865-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1550664389-2865-1-git-send-email-th...@redhat.com -> patchew/1550664389-2865-1-git-send-email-th...@redhat.com * [new tag] patchew/20190220145819.30969-1-berra...@redhat.com -> patchew/20190220145819.30969-1-berra...@redhat.com * [new tag] patchew/20190221183829.31019-1-phi...@redhat.com -> patchew/20190221183829.31019-1-phi...@redhat.com * [new tag] patchew/20190223105421.1290-1-davidkiar...@gmail.com -> patchew/20190223105421.1290-1-davidkiar...@gmail.com * [new tag] patchew/20190227012132.16271-1-da...@gibson.dropbear.id.au -> patchew/20190227012132.16271-1-da...@gibson.dropbear.id.au * [new tag] patchew/cover.1550836631.git.be...@igalia.com -> patchew/cover.1550836631.git.be...@igalia.com Switched to a new branch 'test' fd512d4ee7 hw/sd/sdhci: Move PCI-related code into a separate file === OUTPUT BEGIN === ERROR: Macros with complex values should be enclosed in parenthesis #60: FILE: hw/sd/sdhci-internal.h:326: +#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \ + DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \ + DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \ + \ + /* Capabilities registers provide information on supported WARNING: Block comments use a leading /* on a separate line #64: FILE: hw/sd/sdhci-internal.h:330: + /* Capabilities registers provide information on supported WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 total: 1 errors, 2 warnings, 278 lines checked Commit fd512d4ee7ec (hw/sd/sdhci: Move PCI-related code into a separate file) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1550664389-2865-1-git-send-email-th...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
