Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-23 Thread Paolo Bonzini
On 23/11/2017 03:55, Deepa Srinivasan wrote: > I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of > the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as > Kevin noted, read and write were using the QEMUIOVector in BlkRwCo. > > To avoid changes to the callers o

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Deepa Srinivasan
I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as Kevin noted, read and write were using the QEMUIOVector in BlkRwCo. To avoid changes to the callers of blk_aio_ioctl(), I’ll change blk_aio_prwv() to tak

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 19:06, Kevin Wolf wrote: > Am 22.11.2017 um 17:34 hat Paolo Bonzini geschrieben: >> On 22/11/2017 16:33, Deepa Srinivasan wrote: >>> Starting qemu with the following arguments causes qemu to segfault: >>> ... -device lsi,id=lsi0 -drive >>> file=iscsi:<...>,format=raw,if=none,node-nam