On 23/11/2017 03:55, Deepa Srinivasan wrote: > I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of > the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as > Kevin noted, read and write were using the QEMUIOVector in BlkRwCo. > > To avoid changes to the callers of blk_aio_ioctl(), I’ll change > blk_aio_prwv() to take a void pointer instead of QEMUIOVector* and use a > union to hold the buffer in BlkRwCo.
The union is unnecessary. A QEMUIOVector* can be stored in a void* just fine. Paolo