Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2016 at 04:48:06PM +0530, Amit Shah wrote: > On (Tue) 26 Jul 2016 [15:29:36], Cao jin wrote: > > Hi Amit > > > > I will take care of this. > > BTW, did't see it in coverity scan outstanding defects, Do I missed or it is > > checked by other static check tools? > > This is checked

Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-26 Thread Amit Shah
On (Tue) 26 Jul 2016 [15:29:36], Cao jin wrote: > Hi Amit > > I will take care of this. > BTW, did't see it in coverity scan outstanding defects, Do I missed or it is > checked by other static check tools? This is checked with the vmstate static checker -- scripts/vmstate-static-checker.py. The

Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-26 Thread Cao jin
On 07/26/2016 01:01 PM, Amit Shah wrote: On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote: From: Cao jin internal flag msi_in_use in unnecessary, msi_uninit() could be called directly, and msi_enabled() is enough to check device msi state. cc: Markus Armbruster cc: Marcel Apfelbau

Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-25 Thread Amit Shah
On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote: > From: Cao jin > > internal flag msi_in_use in unnecessary, msi_uninit() could be called > directly, and msi_enabled() is enough to check device msi state. > > cc: Markus Armbruster > cc: Marcel Apfelbaum > cc: Paolo Bonzini > cc: Mi

[Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin internal flag msi_in_use in unnecessary, msi_uninit() could be called directly, and msi_enabled() is enough to check device msi state. cc: Markus Armbruster cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Michael S. Tsirkin Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Re