On 07/26/2016 01:01 PM, Amit Shah wrote:
On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote:
From: Cao jin <caoj.f...@cn.fujitsu.com>
internal flag msi_in_use in unnecessary, msi_uninit() could be called
directly, and msi_enabled() is enough to check device msi state.
cc: Markus Armbruster <arm...@redhat.com>
cc: Marcel Apfelbaum <mar...@redhat.com>
cc: Paolo Bonzini <pbonz...@redhat.com>
cc: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Markus Armbruster <arm...@redhat.com>
Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
[...]
static void mptsas_reset(DeviceState *dev)
@@ -1375,7 +1370,6 @@ static const VMStateDescription vmstate_mptsas = {
.post_load = mptsas_post_load,
.fields = (VMStateField[]) {
VMSTATE_PCI_DEVICE(dev, MPTSASState),
- VMSTATE_BOOL(msi_in_use, MPTSASState),
This removes vmstate -- please use 'unused' instead of removing this
value.
Flagged by the static checker.
Hi Amit
I will take care of this.
BTW, did't see it in coverity scan outstanding defects, Do I missed or
it is checked by other static check tools?
--
Yours Sincerely,
Cao jin
