Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error

2014-01-01 Thread Peter Maydell
On 1 January 2014 13:56, Stefan Weil wrote: > hw_error is not available for user mode, so this patch fixes Darwin > (which only provides system emulation), but it breaks linking of > m68k-linux-user on Linux hosts. Maybe we need to come up with some better guidelines about when to use the various

Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error

2014-01-01 Thread Michael Tokarev
01.01.2014 17:56, Stefan Weil wrote: > I'm sorry that I have to revoke this patch. Ow. Removed from the trivial-patches git tree. /mjt

Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error

2014-01-01 Thread Stefan Weil
Am 27.12.2013 23:07, schrieb Michael Tokarev: > From: Stefan Weil > > hw_error is already used for target-arm and target-s390x. > Using it for target-m68k fixes this compiler warning with Darwin because > hw_error is declared with QEMU_NORETURN: > > target-m68k/translate.c:671:13: warning: > vari

[Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error

2013-12-27 Thread Michael Tokarev
From: Stefan Weil hw_error is already used for target-arm and target-s390x. Using it for target-m68k fixes this compiler warning with Darwin because hw_error is declared with QEMU_NORETURN: target-m68k/translate.c:671:13: warning: variable 'offset' is used uninitialized whenever switch default