Am 27.12.2013 23:07, schrieb Michael Tokarev: > From: Stefan Weil <s...@weilnetz.de> > > hw_error is already used for target-arm and target-s390x. > Using it for target-m68k fixes this compiler warning with Darwin because > hw_error is declared with QEMU_NORETURN: > > target-m68k/translate.c:671:13: warning: > variable 'offset' is used uninitialized whenever switch default is taken > [-Wsometimes-uninitialized] > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > --- > target-m68k/translate.c | 28 +++++++++------------------- > 1 file changed, 9 insertions(+), 19 deletions(-) >
Hi, I'm sorry that I have to revoke this patch. hw_error is not available for user mode, so this patch fixes Darwin (which only provides system emulation), but it breaks linking of m68k-linux-user on Linux hosts. target-arm and target-s390x use hw_error in conditional code which is not compiled for user emulation, so they don't have this problem. Regards Stefan
