Re: [Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 16:08, Peter Maydell wrote: > On 27 February 2017 at 16:49, Paolo Bonzini wrote: >> The cast is there because sigbus_handler is invoked via sigfd_handler. >> But it feels just wrong to use struct qemu_signalfd_siginfo in the >> prototype of a function that is passed to sigaction. >

Re: [Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-03-17 Thread Peter Maydell
On 27 February 2017 at 16:49, Paolo Bonzini wrote: > The cast is there because sigbus_handler is invoked via sigfd_handler. > But it feels just wrong to use struct qemu_signalfd_siginfo in the > prototype of a function that is passed to sigaction. > > Instead, do a simple-minded conversion of qemu

[Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-02-27 Thread Paolo Bonzini
The cast is there because sigbus_handler is invoked via sigfd_handler. But it feels just wrong to use struct qemu_signalfd_siginfo in the prototype of a function that is passed to sigaction. Instead, do a simple-minded conversion of qemu_signalfd_siginfo to siginfo_t. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-02-24 Thread Paolo Bonzini
The cast is there because sigbus_handler is invoked via sigfd_handler. But it feels just wrong to use struct qemu_signalfd_siginfo in the prototype of a function that is passed to sigaction. Instead, do a simple-minded conversion of qemu_signalfd_siginfo to siginfo_t. Signed-off-by: Paolo Bonzini