On 27 February 2017 at 16:49, Paolo Bonzini <pbonz...@redhat.com> wrote: > The cast is there because sigbus_handler is invoked via sigfd_handler. > But it feels just wrong to use struct qemu_signalfd_siginfo in the > prototype of a function that is passed to sigaction. > > Instead, do a simple-minded conversion of qemu_signalfd_siginfo to > siginfo_t. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > + } else if (info->ssi_signo == SIGIO) { > + si.si_band = info->ssi_band; > + }
This doesn't build on OpenBSD: In file included from /usr/include/sys/signal.h:107:0, from /usr/include/signal.h:38, from /root/qemu/include/qemu/osdep.h:86, from /root/qemu/util/oslib-posix.c:29: /root/qemu/util/oslib-posix.c: In function 'sigaction_invoke': /root/qemu/util/oslib-posix.c:713:12: error: 'union <anonymous>' has no member named '_file' si.si_band = info->ssi_band; ^ I dunno how much we care. thanks -- PMM