Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-06 Thread Markus Armbruster
Peter Maydell writes: > On 6 October 2015 at 06:46, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 5 October 2015 at 20:27, Paolo Bonzini wrote: On 05/10/2015 20:46, Peter Maydell wrote: > The easy fix is to have some suitable ifdeffery in virtio-pci.c, > si

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-06 Thread Peter Maydell
On 6 October 2015 at 06:46, Markus Armbruster wrote: > Peter Maydell writes: > >> On 5 October 2015 at 20:27, Paolo Bonzini wrote: >>> >>> >>> On 05/10/2015 20:46, Peter Maydell wrote: The easy fix is to have some suitable ifdeffery in virtio-pci.c, similar to how we only register the

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 October 2015 at 20:27, Paolo Bonzini wrote: >> >> >> On 05/10/2015 20:46, Peter Maydell wrote: >>> The easy fix is to have some suitable ifdeffery in virtio-pci.c, >>> similar to how we only register the virtio_9p_pci and virtio_scsi_pci >> >> (vhost_scsi_pci) >> >>>

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 20:27, Paolo Bonzini wrote: > > > On 05/10/2015 20:46, Peter Maydell wrote: >> The easy fix is to have some suitable ifdeffery in virtio-pci.c, >> similar to how we only register the virtio_9p_pci and virtio_scsi_pci > > (vhost_scsi_pci) > >> types if they've been configured i

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 20:46, Peter Maydell wrote: > The easy fix is to have some suitable ifdeffery in virtio-pci.c, > similar to how we only register the virtio_9p_pci and virtio_scsi_pci (vhost_scsi_pci) > types if they've been configured into this build. Hmm, actually there's no reason to limit co

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 18:11, Markus Armbruster wrote: > Sigh. I'll stare at the original backtrace some more. Here's one from a debug build (with some reasoning about the cause underneath it). As an aside, thanks to your valgrind example I figured out how to get the test makefile to run tests un

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 October 2015 at 07:49, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 2 October 2015 at 18:20, Markus Armbruster wrote: QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 07:49, Markus Armbruster wrote: > Peter Maydell writes: > >> On 2 October 2015 at 18:20, Markus Armbruster wrote: >>> QMP command device-list-properties regressed in 2.1: it can crash or >>> leave dangling pointers behind. >>> >>> -device FOO,help regressed in 2.2: it no lon

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-04 Thread Markus Armbruster
Peter Maydell writes: > On 2 October 2015 at 18:20, Markus Armbruster wrote: >> QMP command device-list-properties regressed in 2.1: it can crash or >> leave dangling pointers behind. >> >> -device FOO,help regressed in 2.2: it no longer works for >> non-pluggable devices. I tried to fix that s

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-04 Thread Peter Maydell
On 2 October 2015 at 18:20, Markus Armbruster wrote: > QMP command device-list-properties regressed in 2.1: it can crash or > leave dangling pointers behind. > > -device FOO,help regressed in 2.2: it no longer works for > non-pluggable devices. I tried to fix that some time ago[*], but my > fix f

[Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-02 Thread Markus Armbruster
QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO,help regressed in 2.2: it no longer works for non-pluggable devices. I tried to fix that some time ago[*], but my fix failed review. This is my second, more comprehensive try. PATCH