On 5 October 2015 at 20:27, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 05/10/2015 20:46, Peter Maydell wrote: >> The easy fix is to have some suitable ifdeffery in virtio-pci.c, >> similar to how we only register the virtio_9p_pci and virtio_scsi_pci > > (vhost_scsi_pci) > >> types if they've been configured into this build. > > Hmm, actually there's no reason to limit > > common-obj-$(CONFIG_VIRTIO) += virtio-input.o > common-obj-$(CONFIG_VIRTIO) += virtio-input-hid.o > > to CONFIG_LINUX. Does it work to extract them out of the if (which is > only correct for virtio-input-host.o)?
Yes, though as you predicted we then fall over on virtio-input-host-pci. If I bodge that one out in virtio-pci.c then the device-introspect-test passes. thanks -- PMM
