Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Samuel Thibault
Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote: > > +if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) > > +|| (user->has_ipv4 && !user->ipv4)) > > +ipv4 = 0; > > Inconsistent with current qemu style. Should be: > > if ((user->has_ipv6 && user->ipv6 && !user

Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Eric Blake
On 03/24/2016 05:34 PM, Samuel Thibault wrote: > Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and > IPv6-only network environments. > > Signed-off-by: Samuel Thibault > > --- > > @@ -812,10 +822,18 @@ int net_init_slirp(const NetClientOptions *opts, const > char *name, >

[Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. - Reject incoherent configuration (e.g. v