Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote: > > + if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) > > + || (user->has_ipv4 && !user->ipv4)) > > + ipv4 = 0; > > Inconsistent with current qemu style. Should be: > > if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) || > (user->has_ipv4 && !user->ipv4)) {
Ah, I didn't know about that one. I personally prefer it the other way, but alright. > In particular, the missing {} (should) fail ./scripts/checkpatch.pl. Right, sorry, it seems I forgot to re-run the script after the last rework. Samuel