Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*

2017-10-24 Thread Richard Henderson
On 10/24/2017 05:11 AM, Philippe Mathieu-Daudé wrote: >> /* If no temporary was used, be careful not to alias t1 and t0. */ >> -t0 = TCGV_EQUAL(t1, cpu_cc_src) ? cpu_tmp0 : reg; >> +t0 = t1 == cpu_cc_src ? cpu_tmp0 : reg; > As I noticed in a previous patch, this expression is

Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*

2017-10-23 Thread Philippe Mathieu-Daudé
On 10/20/2017 08:19 PM, Richard Henderson wrote: > When we used structures for TCGv_*, we needed a macro in order to > perform a comparison. Now that we use pointers, this is just clutter. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h| 6 ++ > tcg/tcg.h

Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*

2017-10-23 Thread Emilio G. Cota
On Fri, Oct 20, 2017 at 16:19:50 -0700, Richard Henderson wrote: > When we used structures for TCGv_*, we needed a macro in order to > perform a comparison. Now that we use pointers, this is just clutter. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota E.

[Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*

2017-10-20 Thread Richard Henderson
When we used structures for TCGv_*, we needed a macro in order to perform a comparison. Now that we use pointers, this is just clutter. Signed-off-by: Richard Henderson --- tcg/tcg-op.h| 6 ++ tcg/tcg.h | 4 target/cris/translate.c | 6 +++--- target/i386/tran