On 10/24/2017 05:11 AM, Philippe Mathieu-Daudé wrote: >> /* If no temporary was used, be careful not to alias t1 and t0. */ >> - t0 = TCGV_EQUAL(t1, cpu_cc_src) ? cpu_tmp0 : reg; >> + t0 = t1 == cpu_cc_src ? cpu_tmp0 : reg; > As I noticed in a previous patch, this expression is a bit easier/faster > to read/review with parenthesis are used: > > t0 = (t1 == cpu_cc_src ? cpu_tmp0 : reg);
You're right. And I normally write it this way myself, even though operator precedence does not require it. But this is a case of search-and-replace, and I didn't retouch such things. r~
