Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-25 Thread John Snow
On 09/24/2015 02:34 AM, Markus Armbruster wrote: > John Snow writes: > > [...] >> Oh, I see: you're saying ... >> >> each action fetches the property, and if it's true, fail (for 2.5, at >> least) with e.g. a message saying "This property is not [yet?] supported >> for this action" > > Yes. >

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-23 Thread Markus Armbruster
John Snow writes: [...] > Oh, I see: you're saying ... > > each action fetches the property, and if it's true, fail (for 2.5, at > least) with e.g. a message saying "This property is not [yet?] supported > for this action" Yes. > That's simple. I always overcomplicate everything ... Simple sol

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-23 Thread John Snow
On 09/23/2015 07:09 AM, Markus Armbruster wrote: > John, your MUA turned the QMP examples to mush. You may want to teach > it manners. > Ugh, sorry. I apparently can't trust > John Snow writes: > >> On 09/22/2015 06:34 PM, Eric Blake wrote: >>> On 09/22/2015 03:08 PM, John Snow wrote:

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-23 Thread Markus Armbruster
John, your MUA turned the QMP examples to mush. You may want to teach it manners. John Snow writes: > On 09/22/2015 06:34 PM, Eric Blake wrote: >> On 09/22/2015 03:08 PM, John Snow wrote: >>> Eric, Markus: I've CC'd you for some crazy what-if QAPI questions >>> after my R-B on this patch. >>> >

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread John Snow
On 09/22/2015 06:34 PM, Eric Blake wrote: > On 09/22/2015 03:08 PM, John Snow wrote: >> Eric, Markus: I've CC'd you for some crazy what-if QAPI questions >> after my R-B on this patch. >> > >> The current design of this patch is such that the blockdev-backup >> and drive-backup QMP commands are

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread Eric Blake
On 09/22/2015 03:08 PM, John Snow wrote: > Eric, Markus: I've CC'd you for some crazy what-if QAPI questions after > my R-B on this patch. > > The current design of this patch is such that the blockdev-backup and > drive-backup QMP commands are extended for use in the transaction > action. This m

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread John Snow
Eric, Markus: I've CC'd you for some crazy what-if QAPI questions after my R-B on this patch. On 09/21/2015 10:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown awa

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-22 Thread Eric Blake
On 09/21/2015 08:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incre

[Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-21 Thread Fam Zheng
From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case