On 09/21/2015 08:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi <stefa...@redhat.com> > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup with multiple disks can be retried in case of > cancellation/failure. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > Reviewed-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Fam Zheng <f...@redhat.com> > ---
> +++ b/qapi/block-core.json > @@ -735,7 +735,6 @@ > # @on-target-error: #optional the action to take on an error on the target, > # default 'report' (no limitations, since this applies to > # a different block device than @device). > -# > # Note that @on-source-error and @on-target-error only affect background I/O. > # If an error occurs during a guest write request, the device's rerror/werror > # actions will be used. Spurious line deletion when addressing review comment. Maintainer can touch it up for the pull request, so my R-b still stands. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
